[Reflection] NFC: Workaround LLVM C++ standard library weirdness#32406
Merged
davezarzycki merged 1 commit intoswiftlang:masterfrom Jun 16, 2020
Merged
[Reflection] NFC: Workaround LLVM C++ standard library weirdness#32406davezarzycki merged 1 commit intoswiftlang:masterfrom
davezarzycki merged 1 commit intoswiftlang:masterfrom
Conversation
Pull request swiftlang#32244 introduced the use of `std::stringstream` but that causes vtables to be generated and we don't want that.
Contributor
Author
|
@swift-ci please smoke test |
mikeash
approved these changes
Jun 16, 2020
Contributor
mikeash
left a comment
mikeash
left a comment
There was a problem hiding this comment.
LGTM. Sorry for the trouble!
Contributor
Author
|
No problem-o. The usage of |
Contributor
|
These infernal machines are far too complicated. |
Contributor
Author
|
(Hand waving about what we ought to do.) If we're going to use the C++ libraries (standard or otherwise), we ought to have a test that runs |
Contributor
Author
Contributor
|
@davezarzycki we already do stuff like that in the integration suite. See: https://github.com/apple/swift-integration-tests/tree/master/test-snapshot-binaries. If you want to add anything, please feel free to do so! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request #32244 introduced the use of
std::stringstreambut that causes vtables to be generated and we don't want that.